[ANNOUNCEMENT] Dialog module v1.1 released

Classic Servoy
1

This release fixes a few things and adds new features that work in the web client only.
(Smart client uses the plugin dialog)

  • Reversed the order the buttons were shown in the web client. It now matches the way the dialog plugin shows them.
  • Added support for line breaks in the dialog text
  • Added a stylesheet override method. Now you can add the style classes to your own stylesheet
  • Renamed the style classes so they are now more unique
  • Added a dialog width and/or height override method (and a method to reset them to the default values)
  • Added The Great Guesstimator:trade_mark: - A hack really to support variable length buttons depending on the button text.

You can download the Dialog module here.
See for more info in the wiki.
Check out the screenshots.

Enjoy!

2

So the WC buttons are now the reverse of the SC Buttons in 1.1 - was that intended Robert?

Confusing for a user when they expect the exact same in both??

3

ROCLASI:

  1. Reversed the order the buttons were shown in the web client. It now matches the way the dialog plugin shows them.
    [/quote]

Do you take into account then the os you use?
Because are for example the “OK” and “CANCEL” buttons ‘stable’ if you compare windows and the mac?
I didn’t test but i think the Swing dialogs uses system stuff and isn’t it so that in windows you see “ok” , “cancel” and on the mac “cancel”, “ok” ?
(or something like that)

4

yeah, for windows the buttons are reversed now (smart-client versus web-client)

Robert, only tested in MAC (ofcourse!! ;-) ) and there you need to reverse it, because that does de plugins.dialogs also on MAC.

So the reverse-fix should only be done, for MAC:

	if (application.getOSName().match("Mac")) {
		//do the reverse-fix only here
	}
5

I have applied a patch to Robert!

for a quick fix, just goto: dialogs_base.js

and search for this line:

for (i = 0; i < buttonArray.length; i++) {

add just above this line:

	if (!application.getOSName().match("Mac")) {
		buttonArray = buttonArray.reverse()
	}
6

Yep I screwed up on that one.
On Mac the dialog plugin shows the button array completely reversed in comparison with the other platforms.
Will put out a bugfix release ASAP.

7

I posted version 1.1.1 of the Dialog module.

The following things were done:

  • Applied the OS dependent reverse-button patch from Harjo Kompagnie
  • Made the default button highlight also OS dependent