it2be_tools unzip

hi!

i used plugins.it2be_tools.unZip(myFile, false) to extract files after selecting a zip file. I cannot delete “myFile” unless I close the form.

Hi,

I suggest you file an issue at IT2BE’s new ITB2BE-Tools project page.

the problem is in ToolsUtils:

        private static void unpackZipFile( final String directory, final ZipFile zip ) throws IOException {
                final HashMap<String,String> parents = new HashMap<String,String>();
                Enumeration<?> entries = zip.entries();
                while ( entries.hasMoreElements() ) {
                        final ZipEntry ze = (ZipEntry) entries.nextElement();
                        getZipParent( parents, directory, ze );
                }
                entries = zip.entries();
                while ( entries.hasMoreElements() ) {
                        final ZipEntry ze = (ZipEntry) entries.nextElement();
                        final InputStream is = zip.getInputStream( ze );
                        extractZipFileEntry( parents, directory, ze, is, true );
                }
        }

that should be come something like this:

        private static void unpackZipFile( final String directory, final ZipFile zip ) throws IOException {
               try {
                final HashMap<String,String> parents = new HashMap<String,String>();
                Enumeration<?> entries = zip.entries();
                while ( entries.hasMoreElements() ) {
                        final ZipEntry ze = (ZipEntry) entries.nextElement();
                        getZipParent( parents, directory, ze );
                }
                entries = zip.entries();
                while ( entries.hasMoreElements() ) {
                        final ZipEntry ze = (ZipEntry) entries.nextElement();
                        final InputStream is = zip.getInputStream( ze );
                       try{
                        extractZipFileEntry( parents, directory, ze, is, true );
                        } finally {is.close();}
                }
                } finally  { zip.close(); }
        }

Thanks Johan,

Implemented and available later this week!

Hey Marcel,
that’s the beauty of Open Source, isn’t it? ;)

IT2Be:
Thanks Johan,

Implemented and available later this week!

Thanks Marcel.

ptalbot:
Hey Marcel,
that’s the beauty of Open Source, isn’t it? ;)

:slight_smile:

pogie.nocedo:
Thanks Marcel.

You are welcome!