svyDateUtils duration issue - solved

Classic Servoy
1

I was trying to use svyDateutils to replace functionality of the dateUtils plugin, specifically here to get the end date of a duration. So I create a duration:

var vDuration = scopes.svyDateUtils.createDurationFromDates(globals.search_date1,globals.search_date2)
``` and then want to get the end date from a different start date using the duration to calculate the end date:

var vDurationEndDate = vDuration.getEndOfDuration(globals.var_date1)

This however fails with this exception: 
Exception Object: org.mozilla.javascript.EvaluatorException: Can't find method java.util.GregorianCalendar.add(number,org.mozilla.javascript.Undefined)

Looking through svyDateUtils.js it seems there are a couple of omissions in the code. Changing this

this.getEndOfDuration = function(startDate) {
calendar.setTimeInMillis(startDate.getTime());
if (this.negative) {
calendar.add(java.util.Calendar.WEEK_OF_YEAR, -weeks);
calendar.add(java.util.Calendar.DAY_OF_WEEK, -days);
calendar.add(java.util.Calendar.HOUR_OF_DAY, -hours);
calendar.add(java.util.Calendar.MINUTE, -minutes);
calendar.add(java.util.Calendar.SECOND, -seconds);
}
else {
calendar.add(java.util.Calendar.WEEK_OF_YEAR, weeks);
calendar.add(java.util.Calendar.DAY_OF_WEEK, days);
calendar.add(java.util.Calendar.HOUR_OF_DAY, hours);
calendar.add(java.util.Calendar.MINUTE, minutes);
calendar.add(java.util.Calendar.SECOND, seconds);
}
return new Date(calendar.getTimeInMillis());
}


to this

this.getEndOfDuration = function(startDate) {
calendar.setTimeInMillis(startDate.getTime());
if (this.negative) {
calendar.add(java.util.Calendar.WEEK_OF_YEAR, -this.weeks);
calendar.add(java.util.Calendar.DAY_OF_WEEK, -this.days);
calendar.add(java.util.Calendar.HOUR_OF_DAY, -this.hours);
calendar.add(java.util.Calendar.MINUTE, -this.minutes);
calendar.add(java.util.Calendar.SECOND, -this.seconds);
}
else {
calendar.add(java.util.Calendar.WEEK_OF_YEAR, this.weeks);
calendar.add(java.util.Calendar.DAY_OF_WEEK, this.days);
calendar.add(java.util.Calendar.HOUR_OF_DAY, this.hours);
calendar.add(java.util.Calendar.MINUTE, this.minutes);
calendar.add(java.util.Calendar.SECOND, this.seconds);
}
return new Date(calendar.getTimeInMillis());
}


fixes it.