@Sean and Servoy,
Thanks for the webinar about the migration sessions this week…
As expected and you also explained there were some issue’s around styling (just followed your lead) and with SPM (I got a lot of warning and errors about duplicate, just removed them all, also from disk and reinstalled and that dit the job).
The strange thing now is everything looks to work fine if you launch and work with the application:
[attachment=1]01.png[/attachment]
But when you do a browser refresh all styling is gone:
[attachment=0]02.png[/attachment]
Any thoughts?
Kind regards,
Patrick Marelis
that should not happen, can you show this in a sample and make a case?
when you do a browser refresh the less/css should just be pushed again, there shouldn’t be any difference
Hi Johan,
I figured it out. It caused by a pice of the code (from the sample solution). There is an overwrite to custom styles where still the reference was made to the ‘old’ *.less file instead of the *_ng2.less file.
function overrideStyleColors(mainColor, secondaryColor) {
var newColorStyle = {
'MAIN-COLOR': mainColor,
'SECONDARY-COLOR': secondaryColor
}
// set the preferred colors
var mediaOriginal = solutionModel.getMedia('SileramTemplateOriginal_ng2.less');
var cssText = mediaOriginal.getAsString();
// override css
cssText = utils.stringReplaceTags(cssText, newColorStyle);
var media = solutionModel.getMedia('SileramTemplate_ng2.less');
media.setAsString(cssText);
application.overrideStyle('SileramSolution_ng2.less', 'SileramTemplate_ng2.less');
}
Kind regards,
Patrick Marelis
then the question is more why didn’t that show up at first sight…
That is indeed a good question.
I did some debugging and it does run nicely true the code the first run. But not when I do a page refresh in the browser. So to be honest I have no idea but is fixing the issue.
As I mentioned it is part of your standard example so maybe you can have a go with it yourselves?
it is logical that it only runs once.
because this is onsolutionopen and that just registers the override
application.overrideStyle(‘SileramSolution_ng2.less’, ‘SileramTemplate_ng2.less’);
so every time we want to output ‘SileramSolution_ng2.less’ we output ‘SileramTemplate_ng2.less’
Hi,
Oké that makes that clear but not your question: more why didn’t that show up at first sight…
But no longer a issue for me anymore.
I found two other items in the styling of ag-theme-servoy.
The right columns are not fully revealing
[attachment=1]grid.png[/attachment]
The sidenav when collapsing is showing a scroll:
[attachment=0]navleft.png[/attachment]
Is this something I should look into or do you pick this up and comes with a new style update?
for NGGrid that is not styling that is a layout issue that we don’t see
for the Sidenav i dont know also looks more like layout instead of styling
So for both issues we need cases with a sample that demonstrates the issue
The think I know is when working on the none titanium version it works. What am I missing then.
[attachment=0]cols.png[/attachment]
I will try to build a small solutions with these issue’s some were this week…
Just found one more.
In the titanium version the Grid does not scroll from left to right.
there is an issue related to auto-size-columns-to-fit in the latest released NG Grids (both in ng and ti clients) - that will be fixed in the next release (this week) - it could be that you see the same issue
Hi all,
What do I know now:
One:
In my code I have a part to suppressColumnFilter. If you use this the columns does not show op anymore.
var toolPanelOptions = plugins.ngDataGrid.createToolPanelConfig();
toolPanelOptions.suppressColumnFilter = true;
Two
If you have 2 menu items in your sidenav with icons then when collapsing the menu the second (and third and and so on) get extra spacing in between them. Easy to reproduce. That causes with me the extra scroll due to the fact that the icons did no longe fit.
Three
Gridscoll / auto resize: I do only have this in titanium. But will check with the new version.
Hi,
Sorry to inform you but both issue’s remain after the grid-update. Still no scroll from left to right in the grids and extra horizontal spacing in collapsed menu:
pre-titanium:
[attachment=0]pre-tita.png[/attachment]
Titanium:
[attachment=1]tita.png[/attachment]
so make a case with a sample
Here you can see that the height-spacing of the icons in the sidenav is changing when collapsing in tintanium.
The second one is non-titanium
[attachment=0]sidnav_spacing.png[/attachment]
Grid example will cost me some more time.
test.servoy (205 KB)
Hello Guys,
Just found one extra on styling:
Tooltips over labels not showing in Titanium
Before Titanium:
[attachment=0]pre_tita.png[/attachment]
Run with Titatium:
[attachment=1]titanium.png[/attachment]
i fixed that issue in this commit: https://github.com/Servoy/servoy-extra- … 86f144ab0a
We needed to add a space between the icon and the label in TiNG code but that can’t be a none breaking space outside of the label
Hi,
That is good to hear. I do not now if I can test this already of need to wait for the next release.
Tried to replace the file in the zip but that gives an error.
what zip do you mean?
how do you get that zip? because currently you can just use the source (from git) but you need to be on the 2022.03 branch
or build from that branch, but it is not just a zip anymore you need to run “npm install” , “npm run make_release” and that latter will then generate a zip file that can be used
i created one from the 2022.03 branch: https://developer.servoy.com/test/servoyextra.zip
Hi,
On the graphs i found an issue with titanium in combination with the labels. As you can see below the first label becomes undefined:
pre-titanuim:
[attachment=1]pre_titanium.png[/attachment]
tinanium:
[attachment=0]titanium.png[/attachment]
